Review requested for some merge requests
Reply-To set to Mailman Developers. Please check that your replies go there. Or you can comment on MRs directly if you have a GitLab login.
I have three merge requests pending:
[1] https://gitlab.com/mailman/mailman/-/merge_requests/1159 [2] https://gitlab.com/mailman/mailman/-/merge_requests/1160 [3] https://gitlab.com/mailman/mailman/-/merge_requests/1161
[1] fixes the logging initialization bug that prevented the smtp
log
from rotating properly, and maybe some others. I don't think it needs
user review because it's a pure bugfix, but if you're curious and take
a look, and you think it needs better documentation let me know.
[2] adds a configuration variable lmtp_max_size
. This is
user-visible, so review of the documentation in docs/mta.rst and
config/mailman.cfg for clarity and readability would be appreciated.
[3] adds postfix-pgsql support for use of the PostgreSQL database to route Mailman traffic. It's really most useful in an edge case (migration of 10,000+ list Mailman 2 instances), but it's theoretically attractive on the principle of "single source of truth", and possibly for implementing a "microservices" style cloud instance (it eliminates the need for Mailman and Postfix to share a file system). Besides opinions on the value of the general idea I have two specific questions:
- Postfix docs recommend not looking up domains in the database to reduce load on the database server. But on a dedicated Mailman system, you're going to be looking up pretty much everything twice anyway (once to check for local recipient and once to fetch the transport), and my experience so far is that this isn't a big load on Postgres, and it's not a drag on list traffic distribution. Should I implement domain lookup in Postgres? Should it be optional if the lists are being looked up in Postgres?
- The current patch completely disables generation of the
postfix_lmtp alias file, even for the
mailman aliases
command. Should I implement an option to force generation of the files for documentation (and maybe a backup in a very rare and contorted situation where Mailman can see Postgres but Postfix can't)?
Thanks, Steve
[3] sounds beautiful. Will there be something comparable for exim?
Am 06.01.24 um 10:45 schrieb Stephen J. Turnbull:
Reply-To set to Mailman Developers. Please check that your replies go there. Or you can comment on MRs directly if you have a GitLab login.
I have three merge requests pending:
[1] https://gitlab.com/mailman/mailman/-/merge_requests/1159 [2] https://gitlab.com/mailman/mailman/-/merge_requests/1160 [3] https://gitlab.com/mailman/mailman/-/merge_requests/1161
[1] fix
(...)
Jörg Schulz writes:
[3] sounds beautiful. Will there be something comparable for exim?
Exim4 with Mailman >= 3.3.6 doesn't really need it. If you have a single-host setup, the existing configuration is extremely efficient and effective. If you want a networked that doesn't require Exim4 access to Mailman's file system, see https://docs.mailman3.org/projects/mailman/en/latest/src/mailman/docs/mta.ht...
That said, Exim4 doesn't require any patching to Mailman to support a database lookup. From src/mailman/mta/exim4.py:
# Exim4 handles all configuration itself, by finding the list config file.
So just substitute a lookup through the SQL database for the existing "does this file exist?" query in your Exim4 routing configuration. See https://www.exim.org/exim-html-current/doc/html/spec_html/ch-file_and_databa...
The SQL query takes the form
SELECT list_name FROM mailinglist WHERE list_name = '%u' AND mail_host = '%d'
translated to Exim4's configuration language (the %u and %d in that snippet are Postfix syntax).
And before anybody asks, I have no idea about sendmail or qmail. ;-)
Steve
Hello,
thanks for the explanation. The callout verification is a very good way to go - it removes the dependency of a common filesystem, and does not introduce the dependency on a common database.
What needs to be said: Thank you to all the team in this list for the good, concise, helpful, polite messages and the positive attitude in general!
Am 07.01.24 um 17:20 schrieb Stephen J. Turnbull:
Jörg Schulz writes:
[3] sounds beautiful. Will there be something comparable for exim?
Exim4 with Mailman >= 3.3.6 doesn't really need it. If you have a single-host setup, the existing configuration is extremely efficient and effective. If you want a networked that doesn't require Exim4 access to Mailman's file system, see https://docs.mailman3.org/projects/mailman/en/latest/src/mailman/docs/mta.ht...
That said, Exim4 doesn't require any patching to Mailman to support a database lookup. From src/mailman/mta/exim4.py:
# Exim4 handles all configuration itself, by finding the list config file.
So just substitute a lookup through the SQL database for the existing "does this file exist?" query in your Exim4 routing configuration. See https://www.exim.org/exim-html-current/doc/html/spec_html/ch-file_and_databa...
The SQL query takes the form
SELECT list_name FROM mailinglist WHERE list_name = '%u' AND mail_host = '%d'
translated to Exim4's configuration language (the %u and %d in that snippet are Postfix syntax).
And before anybody asks, I have no idea about sendmail or qmail. ;-)
participants (3)
-
J.Schulz
-
Jörg Schulz
-
Stephen J. Turnbull