Search results for "sapiro" - lists.mailman3.org

[MM3-users] Re: Caching problem with templates

by Mark Sapiro

On 6/28/25 22:55, Mark Sapiro wrote: > > This is a different issue. See > https://gitlab.com/mailman/mailman/-/issues/1231 Both this and https://gitlab.com/mailman/mailman/-/issues/1230 are fixed by https://gitlab.com/mailman/mailman/-/merge_requests/1368 and https://gitlab.com/mailman/mailman/-/merge_requests/1367 respectively. The fixes will be in Mailman 3.3.11. This patch ``` --- a/src/mailman/model/cache.py +++ b/src/mailman/model/cache.py @@ -27,7 +27,7 @@ from mailman.database.model import Model from mailman.database.transaction import dbconnection from mailman.database.types import SAUnicode from mailman.interfaces.cache import ICacheManager -from mailman.utilities.datetime import now +from mailman.utilities.datetime import now, ZERO from mailman.utilities.filesystem import safe_remove from public import public from sqlalchemy import Boolean, Column, DateTime, Integer @@ -104,6 +104,8 @@ class CacheManager: """See `ICacheManager`.""" if lifetime is None: lifetime = as_timedelta(config.mailman.cache_life) + if lifetime == ZERO: + return None is_bytes = isinstance(contents, bytes) file_id = self._key_to_file_id(key) # Is there already an unexpired entry under this id in the database? @@ -124,7 +126,7 @@ class CacheManager: """See `ICacheManager`.""" entry = store.query(CacheEntry).filter( CacheEntry.key == key).one_or_none() - if entry is None: + if entry is None or entry.expires_on <= now(): return None file_path, dir_path = self._id_to_path(entry.file_id) with ExitStack() as resources: ``` implements both fixes. -- Mark Sapiro <mark(a)msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan

11 months, 3 weeks

[MM3-users] Re: Mailman3 breaking DKIM signatures

by Mark Sapiro

On 1/23/25 12:53 AM, Danil Smirnov via Mailman-users wrote: > > чт, 23 янв. 2025 г., 03:15 Mark Sapiro <mark(a)msapiro.net>: > >> >> You could try a patch like >> ``` >> --- a/src/mailman/runners/lmtp.py >> +++ b/src/mailman/runners/lmtp.py >> @@ -186,7 +186,8 @@ class LMTPHandler: >> listnames = set(getUtility(IListManager).names) >> # Parse the message data. If there are any defects in the >> # message, reject it right away; it's probably spam. >> - msg = email.message_from_bytes(envelope.content, Message) >> + msg = email.message_from_bytes(envelope.content, Message, >> + policy=email.policy.Compat32(max_line_length=0)) >> msg.set_unixfrom(envelope.mail_from) >> except Exception: >> elog.exception('LMTP message parsing') >> ``` >> This should prevent folding headers, but this is problematic. It may be >> that the incoming message contains a folded header and this change will >> not fold it in the outgoing message. > > > Doesn't this parameter fits better? > > https://docs.python.org/3/library/email.policy.html#email.policy.EmailPolic… That would be better except Mailman uses the legacy email.message.Message class whose policy is Compat32 and the Compat32 policy doesn't accept refold_source. -- Mark Sapiro <mark(a)msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan

1 year, 4 months

[MM3-users] Re: Twitter OAuth2

by Mark Sapiro

On 12/28/22 11:37, Odhiambo Washington wrote: > On Wed, Dec 28, 2022 at 8:23 PM Mark Sapiro <mark(a)msapiro.net> wrote: > >> On 12/27/22 21:46, Odhiambo Washington wrote: >>> On Tue, Dec 27, 2022 at 8:08 PM Mark Sapiro <mark(a)msapiro.net> wrote: >>>> >>>> I see from another post that you've decided against using Twitter, but >>>> to answer the question, Twitter does not require adding anything to >>>> SOCIALACCOUNT_PROVIDERS. >>>> >>> >>> I tried it and ended up with: >>> >>> ERROR 2022-12-28 08:40:18,895 97440 django.request Internal Server Error: >>> /accounts/twitter/login/ >>> Traceback (most recent call last): >> ... >>> allauth.socialaccount.models.SocialApp.DoesNotExist: SocialApp matching >>> query does not exist. >> >> >> Do you have >> >> 'allauth.socialaccount.providers.twitter', >> >> in INSTALLED_APPS? >> > > Here is what I have in settings_local.py: > > INSTALLED_APPS = ( > 'hyperkitty', > 'postorius', > 'django_mailman3', > # Uncomment the next line to enable the admin: > 'django.contrib.admin', > # Uncomment the next line to enable admin documentation: > 'django.contrib.admindocs', > 'django.contrib.auth', > 'django.contrib.contenttypes', > 'django.contrib.sessions', > 'django.contrib.sites', > 'django.contrib.messages', > 'django.contrib.staticfiles', > 'rest_framework', > 'django_gravatar', > 'compressor', > 'haystack', > 'django_extensions', > 'django_q', > 'allauth', > 'allauth.account', > 'allauth.socialaccount', > #'django_mailman3.lib.auth.fedora', > #'allauth.socialaccount.providers.openid', > 'allauth.socialaccount.providers.github', > #'allauth.socialaccount.providers.gitlab', > 'allauth.socialaccount.providers.google', > 'allauth.socialaccount.providers.facebook', > 'allauth.socialaccount.providers.twitter', > #'allauth.socialaccount.providers.stackexchange', > ) Did you add an app at https://site.name/admin/socialaccount/socialapp/ with twitter as a provider? See https://django-allauth.readthedocs.io/en/latest/providers.html#twitter-oaut… -- Mark Sapiro <mark(a)msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan

3 years, 5 months

[MM3-users] Re: clicking on a username when viewing a thread results in "Page not found"

by Mark Sapiro

On 6/26/23 9:26 PM, Ken Alker wrote: > Mark Sapiro wrote: >> This is a problem. That link goes to, e.g., >> https://example.com/archives/users/<user_id>/. What do you get if you >> strip the user_id and just go to what >> https://example.com/archives/users/ translates to on your system? >> You should get a page saying >> Not implemented >> >> This feature has not been implemented yet, sorry. >> >> If you get a 404, there is an issue with your web server configuration >> or maybe your top level urls.py. > > I get "Not implemented". I do not get a 404 error. That indicates there is some corruption somewhere. I need to research it to figure out where, but the issue is the <user_id> in https://example.com/archives/users/<user_id>/ doesn't exist. Are the crons - https://docs.mailman3.org/en/latest/install/virtualenv.html#cron-jobs-for-m… running? If they are, the hyperkitty sync_mailman job should run daily and might fix this. You can also run `mailman_web mailman_sync` manually. -- Mark Sapiro <mark(a)msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan

2 years, 11 months

[MM3-users] Re: Post-installation documentation?

by Mark Sapiro

On 11/24/21 7:50 PM, Stephen J. Turnbull wrote: > Mark Sapiro writes: > > > Here are the steps to migrate a 2.1 list named `alist(a)example.com` and > > its archives. > > This is documented at https://docs.list.org/en/latest/ (prominent link > in sidebar). This appears to be completely different from > https://docs.mailman3.org/ (and https://mailman.readthedocs.io/ which > I guess is just a redirect). But it looks like the sources are in the > some gitlab repo?! Both docs.list.org and docs.mailman3.org are CNAMEs the resolve ultimately to readthedocs.io. I.e. they both get to the same readthedocs pages the source for which is the https://gitlab.com/mailman/mailman-suite-doc project. https://mailman.readthedocs.io/ also goes readthedocs.io, but to the documentation for Mailman core rather than that for Mailman Suite. > > Did you specify the list's fqdn as in > > https://www.example.com/archives/list/list@example.com/ > > That's not an FQDN, though. "example.com" might be one, but that > whole thing is the URL to the archive. I meant did he go to a url like https://www.example.com/archives/list/list@example.com/ as opposed to https://www.example.com/archives/list/list/ -- Mark Sapiro <mark(a)msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan

4 years, 6 months

[MM3-users] Re: nginx configuration on a multitasking server

by Mark Sapiro

On 12/22/21 7:54 PM, David Newman wrote: > On 12/22/21 7:29 PM, Mark Sapiro wrote: > >> This looks like a uwsgi issue as discussed at >> https://lists.mailman3.org/archives/list/mailman-users@mailman3.org/thread/… >> although that's with apache and not nginx so it may not be. > > If I'm reading the thread correctly, it's Apache workarounds to an > underlying Debian issue, so I agree it may not apply with nginx. I think you're correct that it doesn't apply to nginx, but the symptom is not the same. It is not a Debian issue per se. It is an Apache change that got installed with a Debian update, but the underlying issue is with Apache. See https://lists.mailman3.org/archives/list/mailman-users@mailman3.org/message… > There are 260 files named 'urls.py' under /opt/mailman, mostly for > socialaccount stuff. > > Where does that change go? All files? Or just this one: > > /opt/mailman/venv/lib/python3.9/site-packages/postorius/urls.py Not that one. The one whose content looks like https://gitlab.com/mailman/mailman-web/-/blob/master/mailman_web/urls.py. It is probably in the same directory as your Django settings. -- Mark Sapiro <mark(a)msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan

4 years, 5 months

[MM3-users] Re: (venv) mailman-web migrate (as explained) fails with "django.core.exceptions.ImproperlyConfigured: allauth.account.middleware.AccountMiddleware must be added to settings.MIDDLEWARE"

by Mark Sapiro

On 10/21/23 09:58, Mark Sapiro wrote: > You can verify this by activating your > venv and doing > ``` > >>> MAILMAN_REST_API_USER > Traceback (most recent call last): > File "<stdin>", line 1, in <module> > NameError: name 'MAILMAN_REST_API_USER' is not defined > >>> MAILMAN_REST_API_USER > Traceback (most recent call last): > File "<stdin>", line 1, in <module> > NameError: name 'MAILMAN_REST_API_USER' is not defined > >>> MAILMAN_REST_API_PASS > Traceback (most recent call last): > File "<stdin>", line 1, in <module> > NameError: name 'MAILMAN_REST_API_PASS' is not defined > >>> from mailman_web.settings.mailman import * > >>> MAILMAN_REST_API_USER > 'restadmin' > >>> MAILMAN_REST_API_PASS > 'restpass' > >>> > ``` Omitted in the above was invoking Python as in ``` (venv) mark@msapiro:~$ python Python 3.9.16 (main, Dec 11 2022, 12:49:23) [GCC 9.4.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> MAILMAN_REST_API_USER etc, as above ``` -- Mark Sapiro <mark(a)msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan

2 years, 7 months

[MM3-users] Re: mailman3-web and the django middleware problem

by Mark Sapiro

On 4/25/24 22:30, Thomas Stein wrote: > Am 2024-04-26 00:52, schrieb Mark Sapiro: >> One thing you could try is in settings_local.py, put >> ``` >> from settings import MIDDLEWARE >> x = list(MIDDLEWARE) >> x.insert(0, 'allauth.account.middleware.AccountMiddleware') >> MIDDLEWARE = x >> ``` >> to work around the NameError. > > After that I get: > > File "/usr/share/mailman3-web/urls.py", line 20, in <module> > from django.conf.urls import include, url > ImportError: cannot import name 'url' from 'django.conf.urls' > (/usr/lib/python3/dist-packages/django/conf/urls/__init__.py) > dpkg: error processing package mailman3-web (--configure): > installed mailman3-web package post-installation script subprocess > returned error exit status 1 > Errors were encountered while processing: This is another Debian/Ubuntu packaging issue. The packaged /usr/share/mailman3-web/urls.py is incompatible with Django>=4.1. Replace it with the one at https://gitlab.com/mailman/mailman-web/-/blob/master/mailman_web/urls.py?re… > I guess I'll wait for the new package for now. Hopefully that will fix it, or, as Odhiambo suggests, you can uninstall the Debian/Ubuntu packages and install per https://docs.mailman3.org/en/latest/install/virtualenv.html -- Mark Sapiro <mark(a)msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan

2 years, 1 month

[MM3-users] Re: Trying to understand the mailman.cfg from the virtualenv installation guide

by Mark Sapiro

On 9/11/24 01:44, Danil Smirnov via Mailman-users wrote: > Hi Mark, > > ср, 11 сент. 2024 г., 06:26 Mark Sapiro <mark(a)msapiro.net>: > >> On 9/8/24 01:04, unite42--- via Mailman-users wrote: >>> [mta] >>> verp_confirmations: yes >>> verp_personalized_deliveries: yes >>> verp_delivery_interval: 1 >>> >>> What is the background of these recommendations? >> >> >> These settings enable VERP for all list messages. This results in more >> reliable bounce processing. >> > > > Is there any downsides of using it, so it's not enabled by default? With verp_delivery_interval set to 1, Mailman delivers a separate VERPed message to the MTA for each recipient whereas without this, Mailman delivers one or a few messages with multiple recipients each. This can have a performance impact. This is not a consideration for confirmations or personalized deliveries as those messages have only one recipient per message in any case. I.e., there is no performance impact from setting verp_confirmations: yes verp_personalized_deliveries: yes This is not the default because there can be issues with some MTAs dealing with the VERPed envelope sender. -- Mark Sapiro <mark(a)msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan

1 year, 9 months

[MM3-users] Re: Invalid FilterAction: discard. Treating as discard

by Mark Sapiro

On 5/8/19 4:45 AM, Henrik Rasmussen wrote: > Mark Sapiro wrote: > >> I'll post a follow-up with how to change pass_types via mailman shell >> when I work it out. > > Look forward to that, thanks. OK. in mailman shell with your list as 'm' >>> list(m.pass_types) ['multipart/mixed', 'multipart/alternative', 'text/plain'] >>> m.pass_types = ['multipart', 'text/plain', 'text/html'] >>> commit() >>> list(m.pass_types) ['multipart', 'text/plain', 'text/html'] >>> If you want to allow text from forwarded messages, add 'message/rfc822' in the pass_types list above. This setting will allow inspection of all elementary parts within any multipart parts ant will accept only text/plain and text/html. Then if collapse_alternatives is True (settable here or in Postorius), any multipart/alternative parts will by replaced by the first, presumably text/plain, sub-part. Finally, if convert_html_to_plaintext is True (settable here or in Postorius), any remaining text/html parts will be converted to plain text by lynx or whatever is configured as html_to_plain_text_command in mailman.cfg. This will ensure that filter_action is applied only to those messages which have no text/plain or text/html parts. -- Mark Sapiro <mark(a)msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan

7 years, 1 month

Search results for query "sapiro"