Search results for "sapiro" - lists.mailman3.org

[MM3-users] Re: problem with Python's stdlib email module (was: Re: mailman break DKIM signature by modifying body)

by Mark Sapiro

On 6/5/23 10:07, Peter Münster wrote: > On Mon, Jun 05 2023, Mark Sapiro wrote: > >> Changes like those above are due to Python's stdlib email module. > > Could you point me to the code please, where the module is called? Basically, all over. https://gitlab.com/mailman/mailman/-/blob/master/src/mailman/email/message.… defines a mailman.email.message.Message class which is a subclass of Python's email.message.Message class. https://gitlab.com/mailman/mailman/-/blob/master/src/mailman/runners/lmtp.p… makes a mailman.email.message.Message object from the incoming bytes. This object is passed around through many Mailman modules and ultimately https://gitlab.com/mailman/mailman/-/blob/master/src/mailman/runners/outgoi… calls the delivery function which has multiple paths which all wind up at https://gitlab.com/mailman/mailman/-/blob/master/src/mailman/mta/connection… to send the message. and current code (Mailman >=3.3.6) will actually pass the message object to Python's smtplib <https://docs.python.org/3/library/smtplib.html#smtplib.SMTP.send_message> to send it. -- Mark Sapiro <mark(a)msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan

2 years, 8 months

[MM3-users] Re: Bug in email.generator:_handle_text? [was: store/export existing Mailman lists ...]

by Mark Sapiro

On 9/15/22 12:09, Mark Sapiro wrote: > > This apparently confuses the Python email package so that the > get_payload() method returns a list of strings rather than a list of > message objects. Actually, that's not correct. The get_payload() method is returning a list of message objects. It only appears to be a list of strings because this is a mailman.email.message.Message object whose __repr__() method returns the content as a string. The real issue is the missing Content-Type: header which implies the content is text/plain. What I think is happening is the original message is parsed into a multipart/alternative Message object with payload of the text/plain and text/html subparts. Then something deletes the top level Content-Type: header which makes the message appear to be text/plain, yet get_payload() still returns the list of two subparts. So the real issue is what's removing all those headers from the anonymized message. I think there must be some issue with the configured anonymous_list_keep_headers or the code in mailman/handlers/cleanse.py is somehow corrupted. -- Mark Sapiro <mark(a)msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan

3 years, 5 months

[MM3-users] Re: Moderation Action Changed After Import

by Mark Sapiro

On 2/12/21 1:02 PM, Brian Carpenter wrote: > On 2/12/21 3:14 PM, Mark Sapiro wrote: >> It seems you imported to an existing list with import21. This is >> probably not a good idea. >> >> Those members who were moderated members of the MM 2.1 list will have >> their moderation action set to Hold, Reject or Discard based on the 2.1 >> list setting. > > I don't understand. Does not the import21 script require the Mailman 3 > list to be created first? The Mailman 3 list was new with no members > when I ran the import script. Yes, You did the right thing. I was mislead by "He said the previous moderation was the list's default which was hold for moderation." which is Mailman 3 terminology. The list does need to be created first, but it should be a new list with no members, owners, etc., not an operational Mailman 3 list. So, it seems that most of the members of the MM 2.1 list were moderated and the list's member_moderation_action was Reject. Is this not the case? -- Mark Sapiro <mark(a)msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan

5 years

[MM3-users] Re: Is there a way of recording bounce messages?

by Mark Sapiro

On 9/28/23 11:15, Mark Sapiro wrote: > > Lets say you have a few problem lists, list1(a)example.com and > list2(a)example.com. Put the following in Postfix main.cf > ``` > virtual_alias_domains = example.com > virtual_alias_maps = regexp:/etc/postfix/temp-aliases > ``` > Then create /etc/postfix/temp-aliases with this content > ``` > list1-bounces(a)example.com user(a)example.net > list2-bounces(a)example.com user(a)example.net > ``` > where user(a)example.net is the address that should receive the bounces. I just realized it's not that simple. The above will bounce all mail to the example.com domain other than that addressed to the two -bounces addresses. A possible fix is to set ``` list1-bounces(a)example.com user(a)example.net list2-bounces(a)example.com user(a)example.net ^(.*)(a)example.com ${1}(a)x.example.com ``` in /etc/postfix/temp-aliases and edit Mailman's var/data/postfix-lmtp and replace all `(a)example.com` with `(a)x.example.com` Another approach is just to edit Mailman's var/data/postfix-lmtp and remove the list1-bounces(a)example.com and list2-bounces(a)example.com entries and add ``` list1-bounces: user(a)example.net list2-bounces: user(a)example.net ``` to /etc/aliases -- Mark Sapiro <mark(a)msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan

2 years, 5 months

[MM3-users] Re: Set domain inactive / archive import from other domain.

by Mark Sapiro

On 09/18/2018 07:14 PM, Johannes Winter wrote: > Am Sat, 15 Sep 2018 09:31:53 -0700 > schrieb Mark Sapiro <mark(a)msapiro.net>: >> >> Why do you think the domain name is an issue? Perhaps the issue is >> there is already one or more messages in the archive and the messages >> you are importing are older. If you don't specify --since to >> hyperkitty_import it won't import messages older than the newest >> message in the existing archive. > > > Thanks a lot for your excellent and fast support! That was the problem. > Maybe it would be wise to include that into the help of the > hyperkitty_import command? > > Although this command successfully imported 3/4 of the huge (1.7GB) > mbox, it stumbled upon an error after some minutes: > https://gitlab.com/mailman/hyperkitty/issues/200 I have added a comment there which see. I'll "fix" this and I'll update the help to note that if not specified, --since defaults to the date of the newest existing message in the archive. -- Mark Sapiro <mark(a)msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan

7 years, 5 months

[MM3-users] Re: After server upgrade debian 11→12 and reinstalling everything in (venv), I got this error when accessing → mailman3/lists

by Mark Sapiro

Wikinaut wrote: > /opt/mailman/mm/var/templates/sites/de$ dir > insgesamt 12 > 4 -rw-r----- 1 mailman mailman 172 21. Sep 20:50 list:member:digest:footer.txt > 4 -rw-rw---- 1 mailman mailman 173 21. Sep 20:47 list:member:generic.footer.txt > 4 -rw-rw---- 1 mailman mailman 173 21. Sep 20:48 list:member:regular:footer.txt As you have noted, it's `site`, not `sites`, but that's not what I'm writing about. In the above, list:member:generic.footer.txt is never used. list:member:generic.footer.txt is an alternate name for both list:member:digest:footer.txt and list:member:regular:footer.txt. it will be used if and only if the primary name is not found. I.e., if both the regular and digest footer templates are the same, you can put the footer template in list:member:generic.footer.txt and that will be used for both but only if the other files are not there. If the other files are there, they will be used and the `generic` file will be ignored. -- Mark Sapiro <mark(a)msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan

5 months, 1 week

[MM3-users] Re: Hyperkitty Error Curiosity

by Mark Sapiro

On 11/12/20 6:59 AM, Brian Carpenter wrote: > On 11/11/20 7:40 PM, Mark Sapiro wrote: >> >> The message has been delivered to the list, but it is not archived. The >> list post has an Archived-At: header with a URL, but the message isn't >> there at all. The only way to get it archived is to correct the message >> defect. > > Does the problematic message (null character) make it to the > hyperkitty_thread table? I thought that saying it is not archived would answer that, but no, nothing about that message is stored in any hyperkitty table. > Can a message with a null character be repaired with an automatic process? Probably, but I don't think HyperKitty should be in the business of attempting to repair message defects. This one issue of a null byte is arguably not a defective message, but rather an issue of storing a null byte in a database field, so maybe something could be done to `cleanse` that data before storing it. If I were going to look at doing that, I would need an example of a problem message, and ideally, an issue in the tracker. -- Mark Sapiro <mark(a)msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan

5 years, 3 months

[MM3-users] Re: Caching problem with templates

by Mark Sapiro

On 6/28/25 22:55, Mark Sapiro wrote: > > This is a different issue. See > https://gitlab.com/mailman/mailman/-/issues/1231 Both this and https://gitlab.com/mailman/mailman/-/issues/1230 are fixed by https://gitlab.com/mailman/mailman/-/merge_requests/1368 and https://gitlab.com/mailman/mailman/-/merge_requests/1367 respectively. The fixes will be in Mailman 3.3.11. This patch ``` --- a/src/mailman/model/cache.py +++ b/src/mailman/model/cache.py @@ -27,7 +27,7 @@ from mailman.database.model import Model from mailman.database.transaction import dbconnection from mailman.database.types import SAUnicode from mailman.interfaces.cache import ICacheManager -from mailman.utilities.datetime import now +from mailman.utilities.datetime import now, ZERO from mailman.utilities.filesystem import safe_remove from public import public from sqlalchemy import Boolean, Column, DateTime, Integer @@ -104,6 +104,8 @@ class CacheManager: """See `ICacheManager`.""" if lifetime is None: lifetime = as_timedelta(config.mailman.cache_life) + if lifetime == ZERO: + return None is_bytes = isinstance(contents, bytes) file_id = self._key_to_file_id(key) # Is there already an unexpired entry under this id in the database? @@ -124,7 +126,7 @@ class CacheManager: """See `ICacheManager`.""" entry = store.query(CacheEntry).filter( CacheEntry.key == key).one_or_none() - if entry is None: + if entry is None or entry.expires_on <= now(): return None file_path, dir_path = self._id_to_path(entry.file_id) with ExitStack() as resources: ``` implements both fixes. -- Mark Sapiro <mark(a)msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan

8 months

[MM3-users] Re: Mailman3 breaking DKIM signatures

by Mark Sapiro

On 1/23/25 12:53 AM, Danil Smirnov via Mailman-users wrote: > > чт, 23 янв. 2025 г., 03:15 Mark Sapiro <mark(a)msapiro.net>: > >> >> You could try a patch like >> ``` >> --- a/src/mailman/runners/lmtp.py >> +++ b/src/mailman/runners/lmtp.py >> @@ -186,7 +186,8 @@ class LMTPHandler: >> listnames = set(getUtility(IListManager).names) >> # Parse the message data. If there are any defects in the >> # message, reject it right away; it's probably spam. >> - msg = email.message_from_bytes(envelope.content, Message) >> + msg = email.message_from_bytes(envelope.content, Message, >> + policy=email.policy.Compat32(max_line_length=0)) >> msg.set_unixfrom(envelope.mail_from) >> except Exception: >> elog.exception('LMTP message parsing') >> ``` >> This should prevent folding headers, but this is problematic. It may be >> that the incoming message contains a folded header and this change will >> not fold it in the outgoing message. > > > Doesn't this parameter fits better? > > https://docs.python.org/3/library/email.policy.html#email.policy.EmailPolic… That would be better except Mailman uses the legacy email.message.Message class whose policy is Compat32 and the Compat32 policy doesn't accept refold_source. -- Mark Sapiro <mark(a)msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan

1 year, 1 month

[MM3-users] Re: Twitter OAuth2

by Mark Sapiro

On 12/28/22 11:37, Odhiambo Washington wrote: > On Wed, Dec 28, 2022 at 8:23 PM Mark Sapiro <mark(a)msapiro.net> wrote: > >> On 12/27/22 21:46, Odhiambo Washington wrote: >>> On Tue, Dec 27, 2022 at 8:08 PM Mark Sapiro <mark(a)msapiro.net> wrote: >>>> >>>> I see from another post that you've decided against using Twitter, but >>>> to answer the question, Twitter does not require adding anything to >>>> SOCIALACCOUNT_PROVIDERS. >>>> >>> >>> I tried it and ended up with: >>> >>> ERROR 2022-12-28 08:40:18,895 97440 django.request Internal Server Error: >>> /accounts/twitter/login/ >>> Traceback (most recent call last): >> ... >>> allauth.socialaccount.models.SocialApp.DoesNotExist: SocialApp matching >>> query does not exist. >> >> >> Do you have >> >> 'allauth.socialaccount.providers.twitter', >> >> in INSTALLED_APPS? >> > > Here is what I have in settings_local.py: > > INSTALLED_APPS = ( > 'hyperkitty', > 'postorius', > 'django_mailman3', > # Uncomment the next line to enable the admin: > 'django.contrib.admin', > # Uncomment the next line to enable admin documentation: > 'django.contrib.admindocs', > 'django.contrib.auth', > 'django.contrib.contenttypes', > 'django.contrib.sessions', > 'django.contrib.sites', > 'django.contrib.messages', > 'django.contrib.staticfiles', > 'rest_framework', > 'django_gravatar', > 'compressor', > 'haystack', > 'django_extensions', > 'django_q', > 'allauth', > 'allauth.account', > 'allauth.socialaccount', > #'django_mailman3.lib.auth.fedora', > #'allauth.socialaccount.providers.openid', > 'allauth.socialaccount.providers.github', > #'allauth.socialaccount.providers.gitlab', > 'allauth.socialaccount.providers.google', > 'allauth.socialaccount.providers.facebook', > 'allauth.socialaccount.providers.twitter', > #'allauth.socialaccount.providers.stackexchange', > ) Did you add an app at https://site.name/admin/socialaccount/socialapp/ with twitter as a provider? See https://django-allauth.readthedocs.io/en/latest/providers.html#twitter-oaut… -- Mark Sapiro <mark(a)msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan

3 years, 2 months

Search results for query "sapiro"