Patch/kludge suggestion and a question on adding accepted addresses
Hi.
I found out that I had a broken email in one of my held messages queues). That gave a HTTP 500 error although that should be fixed . After some digging I found out that where the error occured.
I'd suggest adding a catch for AttributeError similar to the one for KeyError in _HeldMessageBase in rest/post_moderation.py. It solved my immediate problem at least. I run the version from git with the tag 263711b3b7988c7c474e3b8952dc7e0f02f04fa2
The message causing this was probably one where I had sent a minimal email via telnet to the SMTP port and forgot the MessageID-header or something similarily silly. But it prevented me from seeing the held messages-list in postorius.
I have another question: In the old mailman you could add accepted senders without adding them to the list. Is that possible in Mailman 3/Postorius?
cheers. // David
On Apr 23, 2017, at 10:33 PM, David Krantz wrote:
I found out that I had a broken email in one of my held messages queues). That gave a HTTP 500 error although that should be fixed . After some digging I found out that where the error occured.
I'd suggest adding a catch for AttributeError similar to the one for KeyError in _HeldMessageBase in rest/post_moderation.py. It solved my immediate problem at least. I run the version from git with the tag 263711b3b7988c7c474e3b8952dc7e0f02f04fa2
Can you file a bug and attach either the problematic message or the traceback?
The message causing this was probably one where I had sent a minimal email via telnet to the SMTP port and forgot the MessageID-header or something similarily silly. But it prevented me from seeing the held messages-list in postorius.
Did you talk to your MTA's SMTP port, to Mailman's LMTP port, or some other process? It matters because LMTP is the way messages get from the upstream SMTP daemon (e.g. Postfix, Exim) into Mailman, and the LMTP server rejects any messages that don't have a Message-ID.
I have another question: In the old mailman you could add accepted senders without adding them to the list. Is that possible in Mailman 3/Postorius?
You do this by creating a "nonmember" subscription for the sender, and then setting that member's moderation_action to Action.accept.
Cheers, -Barry
On Sun, Apr 23, 2017 at 11:04 PM, Barry Warsaw barry@list.org wrote:
On Apr 23, 2017, at 10:33 PM, David Krantz wrote:
I'd suggest adding a catch for AttributeError similar to the one for KeyError in _HeldMessageBase in rest/post_moderation.py. It solved my immediate problem at least. I run the version from git with the tag 263711b3b7988c7c474e3b8952dc7e0f02f04fa2
Can you file a bug and attach either the problematic message or the traceback?
Will do. I have lost the message (I was too quick in removing it), but I of course still have the stacktrace. And I have a patch for my kludge.
Did you talk to your MTA's SMTP port, to Mailman's LMTP port, or some other process? It matters because LMTP is the way messages get from the upstream SMTP daemon (e.g. Postfix, Exim) into Mailman, and the LMTP server rejects any messages that don't have a Message-ID.
It was to the SMTP port of the MTA. I can try to recreate it although I have better filters now so it might be difficult to get passed to mailman.
I have another question: In the old mailman you could add accepted senders without adding them to the list. Is that possible in Mailman 3/Postorius?
You do this by creating a "nonmember" subscription for the sender, and then setting that member's moderation_action to Action.accept.
Okay. I see no way of doing that in my instance of Postorius but in this case it is okay to do it in the command prompt.
cheers, // David
On 04/24/2017 07:07 AM, David Krantz wrote:
On Sun, Apr 23, 2017 at 11:04 PM, Barry Warsaw barry@list.org wrote:
On Apr 23, 2017, at 10:33 PM, David Krantz wrote:
I have another question: In the old mailman you could add accepted senders without adding them to the list. Is that possible in Mailman 3/Postorius?
You do this by creating a "nonmember" subscription for the sender, and then setting that member's moderation_action to Action.accept.
Okay. I see no way of doing that in my instance of Postorius but in this case it is okay to do it in the command prompt.
Yes. There are still quite a few things that aren't yet exposed in Postorius and probably some not yet exposed in the rest API. In these cases you have to resort to mailman shell (aka mailman withlist).
-- Mark Sapiro mark@msapiro.net The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
participants (3)
-
Barry Warsaw -
David Krantz -
Mark Sapiro