Mailman notify generating emails for request that aren't visible.
Hi,
We’re running mailman 3.3.4 (about to upgrade to 3.3.5 this week). I enabled mailman notify cron a few weeks ago to email out any pending requests for admins. I’ve now got multiple lists that keep emailing out the same outstanding holds but they can’t visible in the GUI. The requests are all duplicates as well. This is a redacted example email:
-----Original Message----- From: mailman-alerts@example.commailto:mailman-alerts@example.com Sent: Monday, 1 November 2021 8:10 AM To: somelist-owner@lists.example.commailto:somelist-owner@lists.example.com Subject: The somelist@lists.example.commailto:somelist@lists.example.com list has 4 moderation requests waiting.
The somelist@lists.example.commailto:somelist@lists.example.com list has 4 moderation requests waiting.
Held Unsubscriptions: User: john.smith@maildomain.commailto:john.smith@maildomain.com User: john.smith@maildomain.commailto:john.smith@maildomain.com User: john.smith@maildomain.commailto:john.smith@maildomain.com User: john.smith@maildomain.commailto:john.smith@maildomain.com
Please attend to this at your earliest convenience.
I have multiple lists sending the same email (with the same user repeated 4 times). Where should I be looking in the internals of mailman to try and work out why this user has hidden unsubscription holds?
-Simon
Mr Simon Coggins Principal Systems Engineer | Digital Services Directorate CQUniversity Australia, Level 6.14, 160 Ann Street, Brisbane, QLD 4000 P +61 7 3295 1182 | X 51182 | M +61 408 115 861 | E s.coggins@cqu.edu.aumailto:s.coggins@cqu.edu.au
[https://www.cqu.edu.au/social-media] I respectfully acknowledge the Traditional Owners of the land on which we work and learn, and pay respect to the First Nations Peoples and their Elders, past, present and future. This communication may contain privileged or confidential information. If you have received this in error, please return to sender and delete. CRICOS: 00219C | RTO Code 40939
Just adding to this. I’ve found the outstanding holds in the pending DB:
(venv) [mailman@mailman ~]$ mailman shell -l somelist.lists.example.comhttp://somelist.lists.example.com Welcome to the GNU Mailman shell Use commit() to commit changes. Use abort() to discard changes since the last commit. Exit with ctrl+D does an implicit commit() but exit() does not. The variable 'm' is the somelist.lists.example.comhttp://somelist.lists.example.com mailing list
from zope.component import getUtility from mailman.interfaces.pending import IPendings pendingsdb = getUtility(IPendings) for token, data in pendingsdb.find(m): ... print(token, data) ... aabef620b654354311d3ad4a229df394560d5c66 {'type': 'unsubscription', 'list_id': 'somelist.lists.example.comhttp://somelist.lists.example.com', 'email': 'john.smith@maildomain.commailto:john.smith@maildomain.com', 'display_name': '', 'when': '2021-05-04T00:03:01', 'token_owner': 'moderator'} 916265d88c14a02a63f8405318e25711cb3884d8 {'type': 'unsubscription', 'list_id': 'somelist.lists.example.comhttp://somelist.lists.example.com', 'email': 'john.smith@maildomain.commailto:john.smith@maildomain.com', 'display_name': '', 'when': '2021-05-04T23:01:39', 'token_owner': 'moderator'} f931755050ecad9c315aba95daf36c39ab01526f {'type': 'unsubscription', 'list_id': 'somelist.lists.example.comhttp://somelist.lists.example.com', 'email': 'john.smith@maildomain.commailto:john.smith@maildomain.com', 'display_name': '', 'when': '2021-04-23T00:14:48', 'token_owner': 'moderator'} 3a858fe31618dfe254398a33d1cb71bf224f5e6e {'type': 'unsubscription', 'list_id': 'somelist.lists.example.comhttp://somelist.lists.example.com', 'email': 'john.smith@maildomain.commailto:john.smith@maildomain.com', 'display_name': '', 'when': '2021-04-23T00:15:39', 'token_owner': 'moderator'}
What is the best way to clean these up?
Mr Simon Coggins Principal Systems Engineer | Digital Services Directorate CQUniversity Australia, Level 6.14, 160 Ann Street, Brisbane, QLD 4000 P +61 7 3295 1182 | X 51182 | M +61 408 115 861 | E s.coggins@cqu.edu.aumailto:s.coggins@cqu.edu.au
[https://www.cqu.edu.au/social-media] I respectfully acknowledge the Traditional Owners of the land on which we work and learn, and pay respect to the First Nations Peoples and their Elders, past, present and future. This communication may contain privileged or confidential information. If you have received this in error, please return to sender and delete. CRICOS: 00219C | RTO Code 40939
On 1 Nov 2021, at 11:11 am, Simon Coggins
Hi,
We’re running mailman 3.3.4 (about to upgrade to 3.3.5 this week). I enabled mailman notify cron a few weeks ago to email out any pending requests for admins. I’ve now got multiple lists that keep emailing out the same outstanding holds but they can’t visible in the GUI. The requests are all duplicates as well. This is a redacted example email:
-----Original Message----- From: mailman-alerts@example.commailto:mailman-alerts@example.com Sent: Monday, 1 November 2021 8:10 AM To: somelist-owner@lists.example.commailto:somelist-owner@lists.example.com Subject: The somelist@lists.example.commailto:somelist@lists.example.com list has 4 moderation requests waiting.
The somelist@lists.example.commailto:somelist@lists.example.com list has 4 moderation requests waiting.
Held Unsubscriptions: User: john.smith@maildomain.commailto:john.smith@maildomain.com User: john.smith@maildomain.commailto:john.smith@maildomain.com User: john.smith@maildomain.commailto:john.smith@maildomain.com User: john.smith@maildomain.commailto:john.smith@maildomain.com
Please attend to this at your earliest convenience.
I have multiple lists sending the same email (with the same user repeated 4 times). Where should I be looking in the internals of mailman to try and work out why this user has hidden unsubscription holds?
-Simon
Mr Simon Coggins Principal Systems Engineer | Digital Services Directorate CQUniversity Australia, Level 6.14, 160 Ann Street, Brisbane, QLD 4000 P +61 7 3295 1182 | X 51182 | M +61 408 115 861 | E s.coggins@cqu.edu.aumailto:s.coggins@cqu.edu.au
[https://www.cqu.edu.au/social-media] I respectfully acknowledge the Traditional Owners of the land on which we work and learn, and pay respect to the First Nations Peoples and their Elders, past, present and future. This communication may contain privileged or confidential information. If you have received this in error, please return to sender and delete. CRICOS: 00219C | RTO Code 40939
On 10/31/21 6:11 PM, Simon Coggins wrote:
Hi,
We’re running mailman 3.3.4 (about to upgrade to 3.3.5 this week). I enabled mailman notify cron a few weeks ago to email out any pending requests for admins. I’ve now got multiple lists that keep emailing out the same outstanding holds but they can’t visible in the GUI. The requests are all duplicates as well. This is a redacted example email:
-----Original Message----- From: mailman-alerts@example.commailto:mailman-alerts@example.com Sent: Monday, 1 November 2021 8:10 AM To: somelist-owner@lists.example.commailto:somelist-owner@lists.example.com Subject: The somelist@lists.example.commailto:somelist@lists.example.com list has 4 moderation requests waiting.
The somelist@lists.example.commailto:somelist@lists.example.com list has 4 moderation requests waiting.
Held Unsubscriptions: User: john.smith@maildomain.commailto:john.smith@maildomain.com User: john.smith@maildomain.commailto:john.smith@maildomain.com User: john.smith@maildomain.commailto:john.smith@maildomain.com User: john.smith@maildomain.commailto:john.smith@maildomain.com
Please attend to this at your earliest convenience.
Your lists are configured with Un-Subscription Policy moderate or confirm, then moderate so unsubs require Moderator approval.
What Postorius version is this? Prior to 1.3.3, unsubsubscription requests were not visible in Postorius. In 1.3.3_+ they are available in the Subscription requests dropdown at https://example.com/mailman3/lists/listname.example.com/unsubscription_reque... although they may not be counted in the Subscription requests count badge.
-- Mark Sapiro mark@msapiro.net The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
The version of postorius is 1.3.4
django-mailman3 1.3.5 mailman 3.3.4 mailman-hyperkitty 1.1.0 mailmanclient 3.3.2 postorius 1.3.4
Mr Simon Coggins Principal Systems Engineer | Digital Services Directorate CQUniversity Australia, Level 6.14, 160 Ann Street, Brisbane, QLD 4000 P +61 7 3295 1182 | X 51182 | M +61 408 115 861 | E s.coggins@cqu.edu.aumailto:s.coggins@cqu.edu.au
[https://www.cqu.edu.au/social-media] I respectfully acknowledge the Traditional Owners of the land on which we work and learn, and pay respect to the First Nations Peoples and their Elders, past, present and future. This communication may contain privileged or confidential information. If you have received this in error, please return to sender and delete. CRICOS: 00219C | RTO Code 40939
On 1 Nov 2021, at 12:04 pm, Mark Sapiro
On 10/31/21 6:11 PM, Simon Coggins wrote:
Hi,
We’re running mailman 3.3.4 (about to upgrade to 3.3.5 this week). I enabled mailman notify cron a few weeks ago to email out any pending requests for admins. I’ve now got multiple lists that keep emailing out the same outstanding holds but they can’t visible in the GUI. The requests are all duplicates as well. This is a redacted example email:
-----Original Message----- From: mailman-alerts@example.commailto:mailman-alerts@example.commailto:mailman-alerts@example.com Sent: Monday, 1 November 2021 8:10 AM To: somelist-owner@lists.example.commailto:somelist-owner@lists.example.commailto:somelist-owner@lists.example.com Subject: The somelist@lists.example.commailto:somelist@lists.example.commailto:somelist@lists.example.com list has 4 moderation requests waiting.
The somelist@lists.example.commailto:somelist@lists.example.commailto:somelist@lists.example.com list has 4 moderation requests waiting.
Held Unsubscriptions: User: john.smith@maildomain.commailto:john.smith@maildomain.commailto:john.smith@maildomain.com User: john.smith@maildomain.commailto:john.smith@maildomain.commailto:john.smith@maildomain.com User: john.smith@maildomain.commailto:john.smith@maildomain.commailto:john.smith@maildomain.com User: john.smith@maildomain.commailto:john.smith@maildomain.commailto:john.smith@maildomain.com
Please attend to this at your earliest convenience.
Your lists are configured with Un-Subscription Policy moderate or confirm, then moderate so unsubs require Moderator approval.
What Postorius version is this? Prior to 1.3.3, unsubsubscription requests were not visible in Postorius. In 1.3.3_+ they are available in the Subscription requests dropdown at https://example.com/mailman3/lists/listname.example.com/unsubscription_reque...https://example.com/mailman3/lists/listname.example.com/unsubscription_reque... although they may not be counted in the Subscription requests count badge.
--
Mark Sapiro
Mailman-users mailing list -- mailman-users@mailman3.orgmailto:mailman-users@mailman3.org To unsubscribe send an email to mailman-users-leave@mailman3.orgmailto:mailman-users-leave@mailman3.org https://lists.mailman3.org/mailman3/lists/mailman-users.mailman3.org/https://lists.mailman3.org/mailman3/lists/mailman-users.mailman3.org
On 10/31/21 7:15 PM, Simon Coggins wrote:
The version of postorius is 1.3.4
Then you should be able to click Subscription requests even though the badge shows 0 and click Unsubscription Requests in the dropdown. I know it's an issue, but the badge only counts subscription requests pending approval and not unsubscription requests.
-- Mark Sapiro mark@msapiro.net The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
Thats part of the issue. It looks like these are in the PendingsDB but not showing up in the UI. Even if I go into Subscription Requests -> Pending Approvals or Pending Confirmations no pending items are shown at all. But in the pendingDB via mailman shell I can see 3 pending unsubscriptions.
-Simon
Mr Simon Coggins Principal Systems Engineer | Digital Services Directorate CQUniversity Australia, Level 6.14, 160 Ann Street, Brisbane, QLD 4000 P +61 7 3295 1182 | X 51182 | M +61 408 115 861 | E s.coggins@cqu.edu.aumailto:s.coggins@cqu.edu.au
[https://www.cqu.edu.au/social-media] I respectfully acknowledge the Traditional Owners of the land on which we work and learn, and pay respect to the First Nations Peoples and their Elders, past, present and future. This communication may contain privileged or confidential information. If you have received this in error, please return to sender and delete. CRICOS: 00219C | RTO Code 40939
On 1 Nov 2021, at 12:26 pm, Mark Sapiro
On 10/31/21 7:15 PM, Simon Coggins wrote: The version of postorius is 1.3.4
Then you should be able to click Subscription requests even though the badge shows 0 and click Unsubscription Requests in the dropdown. I know it's an issue, but the badge only counts subscription requests pending approval and not unsubscription requests.
--
Mark Sapiro
On 10/31/21 7:29 PM, Simon Coggins wrote:
Thats part of the issue. It looks like these are in the PendingsDB but not showing up in the UI. Even if I go into Subscription Requests -> Pending Approvals or Pending Confirmations no pending items are shown at all. But in the pendingDB via mailman shell I can see 3 pending unsubscriptions.
Both of those only show subscription requests either waiting moderator
approval or waiting user confirmation. You have to go to Unsubscription Requests to see the unsubscriptions.
-- Mark Sapiro mark@msapiro.net The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
Oops sorry I hit send to soon. If I try to go to /lists/listname.example.com/unsubscription_requestshttp://listname.example.com/unsubscription_requests I get a 404, it looks like unsubscription_requestshttp://listname.example.com/unsubscription_requests isn’t in my urls.py list for Postorius?
(venv) [mailman@mailman postorius]$ grep version __init__.py # Software Foundation, either version 3 of the License, or (at your option) # any later version. __version__ = '1.3.4' (venv) [mailman@mailman postorius]$ grep _requests urls.py url(r'^subscription_requests$', list_views.list_subscription_requests, name='list_subscription_requests'),
I’m upgrading this week to:
django-mailman3 1.3.7 mailman 3.3.5 mailman-hyperkitty 1.2.0 mailmanclient 3.3.3 postorius 1.3.6
And I’ve just confirmed that 1.3.6 does have the url endpoint. So I’m guessing it came in in 1.3.5+?
(venv) [mailman@mailman-dev postorius]$ grep version __init__.py # Software Foundation, either version 3 of the License, or (at your option) # any later version. __version__ = '1.3.6' (venv) [mailman@mailman-dev postorius]$ grep _requests urls.py re_path(r'^subscription_requests$', list_views.list_subscription_requests, name='list_subscription_requests'), re_path(r'^unsubscription_requests$', list_views.list_unsubscription_requests, name='list_unsubscription_requests'),
-Simon
Mr Simon Coggins Principal Systems Engineer | Digital Services Directorate CQUniversity Australia, Level 6.14, 160 Ann Street, Brisbane, QLD 4000 P +61 7 3295 1182 | X 51182 | M +61 408 115 861 | E s.coggins@cqu.edu.aumailto:s.coggins@cqu.edu.au
[https://www.cqu.edu.au/social-media] I respectfully acknowledge the Traditional Owners of the land on which we work and learn, and pay respect to the First Nations Peoples and their Elders, past, present and future. This communication may contain privileged or confidential information. If you have received this in error, please return to sender and delete. CRICOS: 00219C | RTO Code 40939
On 1 Nov 2021, at 12:15 pm, Simon Coggins
The version of postorius is 1.3.4
django-mailman3 1.3.5 mailman 3.3.4 mailman-hyperkitty 1.1.0 mailmanclient 3.3.2 postorius 1.3.4
Mr Simon Coggins Principal Systems Engineer | Digital Services Directorate CQUniversity Australia, Level 6.14, 160 Ann Street, Brisbane, QLD 4000 P +61 7 3295 1182 | X 51182 | M +61 408 115 861 | E s.coggins@cqu.edu.aumailto:s.coggins@cqu.edu.au
[https://www.cqu.edu.au/social-media] I respectfully acknowledge the Traditional Owners of the land on which we work and learn, and pay respect to the First Nations Peoples and their Elders, past, present and future. This communication may contain privileged or confidential information. If you have received this in error, please return to sender and delete. CRICOS: 00219C | RTO Code 40939
On 1 Nov 2021, at 12:04 pm, Mark Sapiro
On 10/31/21 6:11 PM, Simon Coggins wrote:
Hi,
We’re running mailman 3.3.4 (about to upgrade to 3.3.5 this week). I enabled mailman notify cron a few weeks ago to email out any pending requests for admins. I’ve now got multiple lists that keep emailing out the same outstanding holds but they can’t visible in the GUI. The requests are all duplicates as well. This is a redacted example email:
-----Original Message----- From: mailman-alerts@example.commailto:mailman-alerts@example.commailto:mailman-alerts@example.com Sent: Monday, 1 November 2021 8:10 AM To: somelist-owner@lists.example.commailto:somelist-owner@lists.example.commailto:somelist-owner@lists.example.com Subject: The somelist@lists.example.commailto:somelist@lists.example.commailto:somelist@lists.example.com list has 4 moderation requests waiting.
The somelist@lists.example.commailto:somelist@lists.example.commailto:somelist@lists.example.com list has 4 moderation requests waiting.
Held Unsubscriptions: User: john.smith@maildomain.commailto:john.smith@maildomain.commailto:john.smith@maildomain.com User: john.smith@maildomain.commailto:john.smith@maildomain.commailto:john.smith@maildomain.com User: john.smith@maildomain.commailto:john.smith@maildomain.commailto:john.smith@maildomain.com User: john.smith@maildomain.commailto:john.smith@maildomain.commailto:john.smith@maildomain.com
Please attend to this at your earliest convenience.
Your lists are configured with Un-Subscription Policy moderate or confirm, then moderate so unsubs require Moderator approval.
What Postorius version is this? Prior to 1.3.3, unsubsubscription requests were not visible in Postorius. In 1.3.3_+ they are available in the Subscription requests dropdown at https://example.com/mailman3/lists/listname.example.com/unsubscription_reque...https://example.com/mailman3/lists/listname.example.com/unsubscription_reque... although they may not be counted in the Subscription requests count badge.
--
Mark Sapiro
Mailman-users mailing list -- mailman-users@mailman3.orgmailto:mailman-users@mailman3.org To unsubscribe send an email to mailman-users-leave@mailman3.orgmailto:mailman-users-leave@mailman3.org https://lists.mailman3.org/mailman3/lists/mailman-users.mailman3.org/https://lists.mailman3.org/mailman3/lists/mailman-users.mailman3.org
On 10/31/21 7:27 PM, Simon Coggins wrote:
Oops sorry I hit send to soon. If I try to go to /lists/listname.example.com/unsubscription_requests http://listname.example.com/unsubscription_requests I get a 404, it looks like unsubscription_requests http://listname.example.com/unsubscription_requests isn’t in my urls.py list for Postorius?
It should be. It was added by https://gitlab.com/mailman/postorius/-/commit/0aba874cae15b1baae2839dca57d3e...
-- Mark Sapiro mark@msapiro.net The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
Looking at the code in gitlab it looks like it wasn’t merged until 1.3.6:
https://gitlab.com/mailman/postorius/-/blob/1.3.6/src/postorius/urls.py#L53
But it’s not in 1.3.5:
https://gitlab.com/mailman/postorius/-/blob/1.3.5/src/postorius/urls.py#L49
Thats ok, I’m going to 1.3.6 in a few days so that should solve my issue.
-Simon
Mr Simon Coggins Principal Systems Engineer | Digital Services Directorate CQUniversity Australia, Level 6.14, 160 Ann Street, Brisbane, QLD 4000 P +61 7 3295 1182 | X 51182 | M +61 408 115 861 | E s.coggins@cqu.edu.aumailto:s.coggins@cqu.edu.au
[https://www.cqu.edu.au/social-media] I respectfully acknowledge the Traditional Owners of the land on which we work and learn, and pay respect to the First Nations Peoples and their Elders, past, present and future. This communication may contain privileged or confidential information. If you have received this in error, please return to sender and delete. CRICOS: 00219C | RTO Code 40939
On 1 Nov 2021, at 12:39 pm, Mark Sapiro
On 10/31/21 7:27 PM, Simon Coggins wrote:
Oops sorry I hit send to soon. If I try to go to /lists/listname.example.com/unsubscription_requestshttp://listname.example.com/unsubscription_requests <http://listname.example.com/unsubscription_requestshttp://listname.example.com/unsubscription_requests> I get a 404, it looks like unsubscription_requests <http://listname.example.com/unsubscription_requestshttp://listname.example.com/unsubscription_requests> isn’t in my urls.py list for Postorius?
It should be. It was added by https://gitlab.com/mailman/postorius/-/commit/0aba874cae15b1baae2839dca57d3e...https://gitlab.com/mailman/postorius/-/commit/0aba874cae15b1baae2839dca57d3e...
--
Mark Sapiro
Mailman-users mailing list -- mailman-users@mailman3.orgmailto:mailman-users@mailman3.org To unsubscribe send an email to mailman-users-leave@mailman3.orgmailto:mailman-users-leave@mailman3.org https://lists.mailman3.org/mailman3/lists/mailman-users.mailman3.org/https://lists.mailman3.org/mailman3/lists/mailman-users.mailman3.org
On 10/31/21 10:42 PM, Simon Coggins wrote:
Looking at the code in gitlab it looks like it wasn’t merged until 1.3.6:
https://gitlab.com/mailman/postorius/-/blob/1.3.6/src/postorius/urls.py#L53
But it’s not in 1.3.5:
https://gitlab.com/mailman/postorius/-/blob/1.3.5/src/postorius/urls.py#L49
Yes, I was mistaken. That code was merged on 14 Feb 2021 and is not in Postorius 1.3.4 which was released on 2 Feb. It should have been in 1.3.5 and I don't know why it is not at https://gitlab.com/mailman/postorius/-/blob/1.3.5/src/postorius/urls.py#L49, but that is moot in any case.
Thats ok, I’m going to 1.3.6 in a few days so that should solve my issue.
OK
-- Mark Sapiro mark@msapiro.net The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
On Nov 1, 2021, at 9:07 AM, Mark Sapiro mark@msapiro.net wrote:
On 10/31/21 10:42 PM, Simon Coggins wrote:
Looking at the code in gitlab it looks like it wasn’t merged until 1.3.6: https://gitlab.com/mailman/postorius/-/blob/1.3.6/src/postorius/urls.py#L53 But it’s not in 1.3.5: https://gitlab.com/mailman/postorius/-/blob/1.3.5/src/postorius/urls.py#L49
Yes, I was mistaken. That code was merged on 14 Feb 2021 and is not in Postorius 1.3.4 which was released on 2 Feb. It should have been in 1.3.5 and I don't know why it is not at https://gitlab.com/mailman/postorius/-/blob/1.3.5/src/postorius/urls.py#L49, but that is moot in any case.
1.3.5 was a security release with no fixed included. It was branched off from 1.3.4 and only the security fix was applied.
One Gitlab pro tip is when you are trying to determine which particular release a particular commit is included in, you can click on the the “…” three dots next to "parent 6096958a master” just under the title and it will show all the tags and branches that this commit is included in.
https://gitlab.com/mailman/postorius/-/commit/0aba874cae15b1baae2839dca57d3e...
for example, is included in 1.3.6b1, 1.3.6 and jquery and master branch.
-- thanks, Abhilash Raj (maxking)
participants (3)
-
Abhilash Raj -
Mark Sapiro -
Simon Coggins