Re: mailman-web compress - Invalid template socialaccount/login_cancelled.html
Despite earlier comments that django-allauth 0.58.1 has been released to fix this issue (and presumably 0.58.2 would have the fix as well), there appears to still be an issue. As Odhiambo indicated with django-allauth==0.57.0, mailman-web compress completes without errors. With django-allauth 0.58.1 and 0.58.2, I still get
(venv) $ mailman-web compress Compressing... Error parsing template socialaccount/signup.html: socialaccount/base.html done Compressed 2 block(s) from 78 template(s) for 1 context(s).
The Invalid template errors for socialaccount/login_cancelled.html and account/verified_email_required.html are gone, but we still have a parsing error.
This is an installation on RHEL9 with python 3.11 based on the virtualenv installation method at https://docs.mailman3.org/en/latest/install/virtualenv.html#virtualenv-insta...
Michael Sanderson
On 11/7/23 16:26, Michael.Sanderson@ubc.ca wrote:
Despite earlier comments that django-allauth 0.58.1 has been released to fix this issue (and presumably 0.58.2 would have the fix as well), there appears to still be an issue. As Odhiambo indicated with django-allauth==0.57.0, mailman-web compress completes without errors. With django-allauth 0.58.1 and 0.58.2, I still get
(venv) $ mailman-web compress Compressing... Error parsing template socialaccount/signup.html: socialaccount/base.html done Compressed 2 block(s) from 78 template(s) for 1 context(s).
I don't think this is fatal, but I have reported it at https://github.com/pennersr/django-allauth/issues/3513
-- Mark Sapiro <mark@msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
On 2023-11-07 19:46:01 -0800 (-0800), Mark Sapiro wrote: [...]
I don't think this is fatal, but I have reported it at https://github.com/pennersr/django-allauth/issues/3513
We've been seeing the same thing in our deployment, I just hadn't found the time to look into it yet. Looks like upstream won't-fixed it, so I guess it was an intentionally backward-incompatible change and the template files will need some minor reworking?
Jeremy Stanley
I believe this is correct, and will need to be fixed on the Mailman side. The practical effects seem to be -- for me at least -- that any of the pages for social logins fail to receive any template styling.
--Jered
----- On Nov 8, 2023, at 10:01 AM, Jeremy Stanley fungi@yuggoth.org wrote:
On 2023-11-07 19:46:01 -0800 (-0800), Mark Sapiro wrote: [...]
I don't think this is fatal, but I have reported it at https://github.com/pennersr/django-allauth/issues/3513
We've been seeing the same thing in our deployment, I just hadn't found the time to look into it yet. Looks like upstream won't-fixed it, so I guess it was an intentionally backward-incompatible change and the template files will need some minor reworking?
Jeremy Stanley
Mailman-users mailing list -- mailman-users@mailman3.org To unsubscribe send an email to mailman-users-leave@mailman3.org https://lists.mailman3.org/mailman3/lists/mailman-users.mailman3.org/ Archived at: https://lists.mailman3.org/archives/list/mailman-users@mailman3.org/message/...
This message sent to jered@convivian.com
Yes, confirmed, and it seems that the page at https://mailman.server/accounts/password/reset/done/ is also missing styling due to this bug.
On Tue, Nov 21, 2023 at 9:41 PM Jered Floyd <jered@convivian.com> wrote:
I believe this is correct, and will need to be fixed on the Mailman side. The practical effects seem to be -- for me at least -- that any of the pages for social logins fail to receive any template styling.
--Jered
----- On Nov 8, 2023, at 10:01 AM, Jeremy Stanley fungi@yuggoth.org wrote:
On 2023-11-07 19:46:01 -0800 (-0800), Mark Sapiro wrote: [...]
I don't think this is fatal, but I have reported it at https://github.com/pennersr/django-allauth/issues/3513
We've been seeing the same thing in our deployment, I just hadn't found the time to look into it yet. Looks like upstream won't-fixed it, so I guess it was an intentionally backward-incompatible change and the template files will need some minor reworking?
Jeremy Stanley
Mailman-users mailing list -- mailman-users@mailman3.org To unsubscribe send an email to mailman-users-leave@mailman3.org https://lists.mailman3.org/mailman3/lists/mailman-users.mailman3.org/ Archived at:
https://lists.mailman3.org/archives/list/mailman-users@mailman3.org/message/...
This message sent to jered@convivian.com
Mailman-users mailing list -- mailman-users@mailman3.org To unsubscribe send an email to mailman-users-leave@mailman3.org https://lists.mailman3.org/mailman3/lists/mailman-users.mailman3.org/ Archived at: https://lists.mailman3.org/archives/list/mailman-users@mailman3.org/message/...
This message sent to danil@smirnov.la
Mark, thanks for your response.
It is perhaps non-fatal, but we do have a different number of templates processed. This is from a successful run with django-allauth==0.57.0. Note the different count of templates from the “failed” processing and this one.
(venv) [mailman@rubytears ~]$ mailman-web compress Compressing... done Compressed 2 block(s) from 124 template(s) for 1 context(s).
Is this compression of web content that will served to clients? Compressed data would be preferred over non-compressed to decrease data volume, but non-compressed will be served if compressed isn’t available?
Michael SandersonOn Nov 7, 2023, at 7:46 PM, Mark Sapiro <mark@msapiro.net> wrote:
[CAUTION: Non-UBC Email]
On 11/7/23 16:26, Michael.Sanderson@ubc.ca wrote:
Despite earlier comments that django-allauth 0.58.1 has been released to fix this issue (and presumably 0.58.2 would have the fix as well), there appears to still be an issue. As Odhiambo indicated with django-allauth==0.57.0, mailman-web compress completes without errors. With django-allauth 0.58.1 and 0.58.2, I still get (venv) $ mailman-web compress Compressing... Error parsing template socialaccount/signup.html: socialaccount/base.html done Compressed 2 block(s) from 78 template(s) for 1 context(s).
I don't think this is fatal, but I have reported it at https://github.com/pennersr/django-allauth/issues/3513
-- Mark Sapiro <mark@msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
Mailman-users mailing list -- mailman-users@mailman3.org To unsubscribe send an email to mailman-users-leave@mailman3.org https://lists.mailman3.org/mailman3/lists/mailman-users.mailman3.org/ Archived at: https://lists.mailman3.org/archives/list/mailman-users@mailman3.org/message/...
This message sent to michael.sanderson@ubc.ca
Michael.Sanderson@ubc.ca writes:
It is perhaps non-fatal, but we do have a different number of templates processed.
Thank you for checking that. I was going to ask, on the theory that if the exception kills the process on template #1, zero templates get processed.
This may not be a problem, at least one of the preparatory steps simply does in advance what would be done lazily at request time. But that needs to be checked.
Steve
participants (6)
-
Danil Smirnov -
Jered Floyd -
Jeremy Stanley -
Mark Sapiro -
Michael.Sanderson＠ubc.ca -
Stephen J. Turnbull