On Tue, Dec 15, 2020, at 3:36 AM, Andreas Barth wrote:
- Andreas Barth (aba@ayous.org) [201213 23:44]:
==> /var/log/mailman3/mailman.log <== Dec 13 23:27:04 2020 (15015) deque: Traceback (most recent call last): File "/srv/prod.mailman/lib/python3/dist-packages/mailman/app/workflow.py", line 69, in __next__ return step() File "/srv/prod.mailman/lib/python3/dist-packages/mailman/app/subscriptions.py", line 227, in _step_sanity_checks MemberRole.member) mailman.interfaces.member.AlreadySubscribedError: t3@$domain is already a MemberRole.member of mailing list t1@$domain
This was a "live" run of mailman (however on my testing box). And, however, still no mail. Now I need to think how to continue.
Further debugging showed that finder.send_response is not True around line 217 in src/mailman/runners/command.py, so the code breaks there.
Turns out that the cause for that behaviour is that I requested the subscribe via the -subscribe-subadress.
If I send the subscribe via a mail to -request with subscribe within the mail, it works as it should and I get a mail back with: t3@$domain is already a MemberRole.member of mailing list t1@$domain
I faintly remember that this behavior was made intentionally to avoid duplicate messages sent for emails sent to -join, -leave and -confirm addresses since they already have some automatic response upon successful completion.
We probably should send the response if the request wasn't completed successfully, like subscribe failed for -join, leave failed for -leave and so on and so forth.
This is the line in code which avoids sending the response for emails sent to sub-addresses like -join, -leave and -confirm: https://gitlab.com/mailman/mailman/-/blob/master/src/mailman/runners/command...
We need some notion of success & failure here to figure out when to send response, currently there is only one response from the the command_finder and that is whether to continue processing or not.
Regards, Andi
Mailman-users mailing list -- mailman-users@mailman3.org To unsubscribe send an email to mailman-users-leave@mailman3.org https://lists.mailman3.org/mailman3/lists/mailman-users.mailman3.org/
-- thanks, Abhilash Raj (maxking)