Am Donnerstag, 13. Oktober 2022, 20:25:44 CEST schrieb Mark Sapiro:
On 10/13/22 10:55, Eggert Ehmke wrote:
It shouldn't have been necessary to apply any patch. The head of the GitLab hyperkitty master branch is already compatible with mistune 2.0.4
strange, I still had the line with the (not working) from mistune.scanner import escape_html, escape_url
maybe because the migration step was not working at that time?
It should have nothing to do with migrations. The command
pip install --upgrade git+https://gitlab.com/mailman/hyperkitty@masterrun as the mailman user with your venv active should have set the content of venv/lib/python3.9/site-packages/hyperkitty/lib/renderer.py to be the same as https://gitlab.com/mailman/hyperkitty/-/blob/master/hyperkitty/lib/renderer. py, but it didn't. I wonder what else didn't get upgraded? Clearly it did do something because mistune was upgraded.
In the meantime I run pip install --upgrade --force-reinstall git+https://gitlab.com/mailman/hyperkitty@master
and that installed the correct renderer.py. Should I do this with all packages?
If you run
pip freezein your active venv,, what versions do you see for the things you upgraded? Do they look for example likeHyperKitty @ git+https://gitlab.com/mailman/hyperkitty@cf585a6588a176e714ec32bbcfe52e8a28 fd7803 ```
Yes that version is installed.