- Mark Sapiro (mark@msapiro.net) [201210 22:51]:
On 12/10/20 11:51 AM, Andreas Barth wrote:
Hi,
I noticed that a mail to -subscribe for an already subscribed user doesn't get any response (about line 225 in mailman/src/mailman/app/subscriptions.py). Same but different for unsubscribe for users not on the list.
I tested and I see this, so there is a bug, but I don't know what the issue is.
Ok, if you consider this a bug it makes sense to fix it upstream and not just locally.
The code you point to should raise AlreadySubscribedError and <https://gitlab.com/mailman/mailman/-/blob/master/src/mailman/commands/eml_me...> should catch it and report, but this doesn't seem to be happening..
Actually I don't see where it should send the mail in the code you refered to, but I'm pretty new to mm3-code and the involved coding guidelines.
I would tend to add something along msg = UserNotification( self.mlist.owner_address, self.mlist.owner_address, subject, text, self.mlist.preferred_language) msg.send(self.mlist) (with appropriate subject, ...) before https://gitlab.com/mailman/mailman/-/blob/master/src/mailman/app/subscriptio... but of course that could be the wrong approach (but as subscriptions.py is sending out mail at other places, that's my first idea).
These things should be fixed, but it's more involved than just a patch to fix the error. For all but trivial fixes, the workflow should be something along the lines of the following. [...]
Thanks, I'll try to have a look into that.
Regards, Andi