Five Year Old Issue
Any chance to get this implemented in time for the next Mailman 3 core release?
https://gitlab.com/mailman/mailman/-/issues/19
It's been 5 years.
-- Brian Carpenter Harmonylists.com Emwd.com
On 3/13/21 8:07 PM, Brian Carpenter wrote:
Any chance to get this implemented in time for the next Mailman 3 core release?
https://gitlab.com/mailman/mailman/-/issues/19
It's been 5 years.
It's not simple. The issue is delivery_mode is an attribute of the member, and when an email join command is processed, there is no member yet because the request is waiting confirmation so join processing can't just set the delivery_mode. It would require an additional argument to the ISubscriptionManager interface register() method for the delivery mode and then carrying that with the subscription workflow until there is actually a member to apply it to. And tests have to be written for all of that.
That's not to say that it shouldn't be fixed, just that it's not something that can be knocked out in an hour. Anybody care to take it on?
-- Mark Sapiro <mark@msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
It turns out Abhilash had done all the heavy lifting on this [1] but I didn't realize it because [2] hadn't been done. Since the rest was easy, [3] now fixes it.
[1] https://gitlab.com/mailman/mailman/-/merge_requests/779 [2] https://gitlab.com/mailman/mailman/-/merge_requests/796 [3] https://gitlab.com/mailman/mailman/-/merge_requests/795
-- Mark Sapiro <mark@msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
On 3/14/21 5:07 PM, Mark Sapiro wrote:
It turns out Abhilash had done all the heavy lifting on this [1] but I didn't realize it because [2] hadn't been done. Since the rest was easy, [3] now fixes it.
[1] https://gitlab.com/mailman/mailman/-/merge_requests/779 [2] https://gitlab.com/mailman/mailman/-/merge_requests/796 [3] https://gitlab.com/mailman/mailman/-/merge_requests/795
Ooops, [2] and [3] are reversed
[2] https://gitlab.com/mailman/mailman/-/merge_requests/795 [3] https://gitlab.com/mailman/mailman/-/merge_requests/796
-- Mark Sapiro <mark@msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
On 3/14/21 8:10 PM, Mark Sapiro wrote:
On 3/14/21 5:07 PM, Mark Sapiro wrote:
It turns out Abhilash had done all the heavy lifting on this [1] but I didn't realize it because [2] hadn't been done. Since the rest was easy, [3] now fixes it.
[1] https://gitlab.com/mailman/mailman/-/merge_requests/779 [2] https://gitlab.com/mailman/mailman/-/merge_requests/796 [3] https://gitlab.com/mailman/mailman/-/merge_requests/795
Ooops, [2] and [3] are reversed
[2] https://gitlab.com/mailman/mailman/-/merge_requests/795 [3] https://gitlab.com/mailman/mailman/-/merge_requests/796
So this means the fix will show up in the next stable release?
-- Brian Carpenter Harmonylists.com Emwd.com
On 3/14/21 5:51 PM, Brian Carpenter wrote:
So this means the fix will show up in the next stable release?
Yes, the fix is committed to gitlab and will be in the next release of Mailman core to PyPI.
-- Mark Sapiro <mark@msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
On 3/14/21 9:25 PM, Mark Sapiro wrote:
On 3/14/21 5:51 PM, Brian Carpenter wrote:
So this means the fix will show up in the next stable release?
Yes, the fix is committed to gitlab and will be in the next release of Mailman core to PyPI.
Thanks Mark! That should make one of my clients very happy.
-- Brian Carpenter Harmonylists.com Emwd.com
On 3/15/21 6:36 AM, Brian Carpenter wrote:
On 3/14/21 9:25 PM, Mark Sapiro wrote:
Yes, the fix is committed to gitlab and will be in the next release of Mailman core to PyPI.
Thanks Mark! That should make one of my clients very happy.
If you want it sooner, the actual fix minus the docs and tests is attached.
-- Mark Sapiro <mark@msapiro.net> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan
participants (2)
-
Brian Carpenter
-
Mark Sapiro